Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update troubleshooting in README.md #198

Merged
merged 5 commits into from
Apr 13, 2021

Conversation

RouNNdeL
Copy link
Contributor

@RouNNdeL RouNNdeL commented Apr 13, 2021

Adds a 'Devices found, but not initialized' section.

Addresses #197

Adds a 'Devices found, but not initialized' section.

Addresses leikoilja#197
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 13, 2021
Copy link
Collaborator

@KapJI KapJI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@DurgNomis-drol
Copy link
Collaborator

Shouldn't it be pointed out to the user in the installation fase instead? Maybe in the config flow?. 😄

Copy link
Owner

@leikoilja leikoilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for contributing, @RouNNdeL 🚀

README.md Outdated
Comment on lines 304 to 305
Your account has to be able to access the devices in your Home.
If unsure, you can check what account you are using in the _Google Home_ app.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Your account has to be able to access the devices in your Home.
If unsure, you can check what account you are using in the _Google Home_ app.
The account you are using with the integration must have access to your google devices.
If unsure, you can check what account and account permissions in the mobile _Google Home_ app.

Copy link
Collaborator

@KapJI KapJI Apr 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leikoilja Sorry, I think the second part became worse :)

How about

If unsure, please check what account you are using in the _Google Home_ app and if you have your devices listed there.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha sound good, thanks for the spot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this sounds the best

Copy link
Contributor Author

@RouNNdeL RouNNdeL Apr 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly changed it, what do you guys think?

@KapJI
Copy link
Collaborator

KapJI commented Apr 13, 2021

@DurgNomis-drol it can be, but that's more advanced implementation 🙂

@RouNNdeL
Copy link
Contributor Author

Awesome! Thanks for contributing, @RouNNdeL

Thank you guys, for the awesome integration 😄

README.md Outdated Show resolved Hide resolved
@KapJI KapJI merged commit a75e379 into leikoilja:master Apr 13, 2021
@RouNNdeL RouNNdeL deleted the docs/correct-account branch April 13, 2021 13:35
@KapJI
Copy link
Collaborator

KapJI commented Apr 13, 2021

Thanks @RouNNdeL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants